Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional Welsh language support to the Character Count component #1038

Closed
wants to merge 1 commit into from

Conversation

robpataki
Copy link

Add optional Welsh language support to the new Character Count component to comply with the UK Government language guidelines.

@robpataki
Copy link
Author

Good morning all, I was just wondering - could someone please have a look at my PR? Thanks!

@36degrees
Copy link
Contributor

Hi @robertpataki,

This is a totally valid approach which solves your particular use case, but we need to find a way to support localisation consistently in a way that will work for different types of components and for other languages. For that reason, we’re not going to be able to accept this pull request.

We hope that we’ll be able to look properly at localisation early next year. In the mean time, we suggest that you fork and vendor in this component and make the adjustments in the service you’re working on.

Thanks for taking the time to propose this, and for your patience.

@36degrees 36degrees closed this Oct 30, 2018
@robpataki
Copy link
Author

Hey @36degrees, makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants