Renames js- css prefix to govuk-js-
#1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1444
aliuk2012
force-pushed
the
al/prefix-js-classnames
branch
from
59ae008
to
2fd9824
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1444
aliuk2012
force-pushed
the
al/prefix-js-classnames
branch
from
2fd9824
to
fb3da0f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1444
NickColley
reviewed
Jun 12, 2019
|
does this change extend to the template? https://github.com/alphagov/govuk-frontend/blob/master/src/template.njk#L31 |
|
Hi @kr8n3r, No it doesn't, the team decided that As you pointed out with this line of code, if JavaScript fails or is disabled then 'js-enabled' would not be added to the |
|
One big reason to avoid changing |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1444
NickColley
reviewed
Jun 12, 2019
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1444
NickColley
reviewed
Jun 13, 2019
NickColley
approved these changes
Jun 13, 2019
aliuk2012
force-pushed
the
al/prefix-js-classnames
branch
from
3c8f32a
to
8608c21
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1444
Currently two components(character count & header) have `js-` interaction hooks. Unfortunately we have found somes instances where other 3rd party js or legacy js (govuk-elements etc) had some unexpected behaviour with the components and in some cases raised js errors. We decided as a team that we should instead namespace (using `govuk-js`) these hooks so that we have confidence in the initialising and interacting on a page with other scripts.
aliuk2012
force-pushed
the
al/prefix-js-classnames
branch
from
8608c21
to
a9c8251
Compare
peteryates
added a commit
to x-govuk/govuk-form-builder
that referenced
this pull request
Aug 5, 2019
Again, this is due to the namespacing changes[0] made in V3 of the GOV.UK Design System [0] alphagov/govuk-frontend#1444
4 tasks
peteryates
added a commit
to x-govuk/govuk-form-builder
that referenced
this pull request
Jan 9, 2020
Again, this is due to the namespacing changes[0] made in V3 of the GOV.UK Design System [0] alphagov/govuk-frontend#1444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently two components(character count & header) have
js-interactionhooks. Unfortunately we have found somes instances where other 3rd party js or
legacy js (govuk-elements etc) had some unexpected behaviour with
the components and in some cases raised js errors.
We decided as a team that we should instead namespace (using
govuk-js)these hooks so that we have confidence in the initialising and interaction of the components on a page with other scripts.
fixes #1270