[As part of release] Updates the docs to point to the right files #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1466
aliuk2012
force-pushed
the
al/namespacing-doc-update
branch
from
0eb8483
to
c6eb7ee
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1466
NickColley
reviewed
Jun 21, 2019
aliuk2012
force-pushed
the
al/namespacing-doc-update
branch
from
c6eb7ee
to
8691f96
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1466
aliuk2012
force-pushed
the
al/namespacing-doc-update
branch
from
8691f96
to
6b02958
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1466
aliuk2012
force-pushed
the
al/namespacing-doc-update
branch
from
6b02958
to
d71668a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1466
7 tasks
36degrees
reviewed
Jul 10, 2019
|
Unless we change the default branch to a v2.X tag merging this would make the installation docs incorrect until we do the v3.0.0 release so I've put a blocked label on this. |
aliuk2012
force-pushed
the
al/namespacing-doc-update
branch
from
d71668a
to
e8bf88a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1466
|
I've addressed @36degrees comment on not having two options to import js. Hopefully this is now in a state to be ready to merge once we do a v3 release |
m-green
reviewed
Jul 12, 2019
| @@ -20,8 +20,6 @@ Components must: | |||
|
|
|||
| Component folder and files should be singular, except in cases where they are more commonly used in groups, for example, radios, breadcrumbs and checkboxes. | |||
|
|
|||
| An example component exists in `src/components/component-example`. | |||
|
|
|||
| Use this as the basis for creating new components. | |||
There was a problem hiding this comment.
Should the "Use this as the basis..." line be removed as well? 'This' seems to refer to the example component that we've now removed reference to.
There was a problem hiding this comment.
Yep, I'll update this now.
Great spot 👀
NickColley
changed the title
As part of namespacing, we need to update the links the docs point to so that they are still valid and do not break. We also needed to update the examples to show how to use the new namespace.
36degrees
force-pushed
the
al/namespacing-doc-update
branch
from
e8bf88a
to
d409da8
Compare
NickColley
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of namespacing, we need to update the links the docs point to
so that they are still valid and do not break.