Update with edited version of v3.0.0 (unreleased) changelog #1492

m-green · 2019-07-12T10:34:05Z

This is the edited version of the v3.0.0 release note in CHANGELOG.md. (The same content - with a summary and updating links - will be used in the GitHub release notes this time).

It's already been 2i'd for style by another technical writer.

Please review for:

factual accuracy
any missing changes in this release.

Following review and before publication we need to:

add missing links
copy to the GitHub release note and add the summary

Add the edited version of the v3.0.0 release note to CHANGELOG.md.

NickColley · 2019-07-12T11:47:40Z

CHANGELOG.md

-  govuk-frontend uses `.govuk-link:focus`. This fix makes govuk-frontend
-  selector more specific `.govuk-link:link:focus` but only when compatibility
-  mode is being used.
+If your page wrapper does not have components above the main section, you no longer need to use the [`govuk-main-wrapper--l` modifier class](https://design-system.service.gov.uk/styles/layout/#exploded-view-of-page-wrappers-without-a-back-link-breadcrumbs-or-phase-banner) to increase the vertical space above the content.


This needs to be updated based on #1493

NickColley · 2019-07-12T11:51:38Z

CHANGELOG.md

@@ -2,510 +2,321 @@

 ## Unreleased 3.0.0 (Breaking release)


We need to do a link check...

hannalaakso

Looks really good 🙌 I've left some minor comments

CHANGELOG.md

hannalaakso · 2019-07-15T13:03:28Z

CHANGELOG.md


- Ensure GOV.UK Frontend component selectors cannot conflict when initialised
+If you're using HTML or custom JavaScript, change:


What would be an example of using custom Javascript in this context?

hannalaakso · 2019-07-15T13:28:48Z

CHANGELOG.md


-  Fixes issues with govuk-fronted javascript clashing with govuk-template/govuk-element and potentially other third-party javascript libraries using `js-` class names as hooks.
+#### If you’re using Sass


Could we say "GOV.UK Frontend Sass".

I've added this to a list of potential post-release style changes.

hannalaakso · 2019-07-15T13:29:46Z

CHANGELOG.md


- Spacing of tabs list updated to be more inline with similar lists on GOV.UK and the Design System
+####  If you’re using Javascript


Could we say "GOV.UK Frontend Javascript"

I've added this to a list of potential post-release style changes.

hannalaakso · 2019-07-15T13:37:05Z

CHANGELOG.md


-  If you are using HTML, you will need to add the `govuk-` prefix to any `[data-module]` attributes.
+1. Change your `nunjucks.configure` property so it only includes the  `node_modules/govuk-frontend/` directory:


I guess they might still want to configure the entire node_modules for some other purpose 🤷‍♀

The meaning of "only" is a bit opaque here. The array could contain other values.

+1 - I think it's very likely that the user will be using nunjucks partials / layouts from elsewhere in their own application.

Thanks both - so would it be more like this: "In your nunjucks.configure property, change /frontend/ to /govuk-frontend/"? (I've added this in 217e12a)

CHANGELOG.md

hannalaakso · 2019-07-15T13:40:30Z

CHANGELOG.md


- Fix issue where link underlines sit too low in Firefox
+If you're using HTML, add the SVG code from the [start button example in the Design System](https://design-system.service.gov.uk/components/button/#start-buttons).


Maybe "HTML <svg> element"

I've added this to our list of potential post-release style questions.

CHANGELOG.md

36degrees · 2019-07-16T15:30:10Z

CHANGELOG.md


-  If you are using HTML, you will need to add the `govuk-` prefix to any `[data-module]` attributes.
+1. Change your `nunjucks.configure` property so it only includes the  `node_modules/govuk-frontend/` directory:


+1 - I think it's very likely that the user will be using nunjucks partials / layouts from elsewhere in their own application.

NickColley · 2019-07-17T13:32:45Z

CHANGELOG.md

@@ -77,7 +77,7 @@ If you're using HTML or custom JavaScript, change:

 #### If you’re using Nunjucks

-1. Change your `nunjucks.configure` property so it only includes the  `node_modules/govuk-frontend/` directory:
+1. In your `nunjucks.configure` property, change `/frontend/` to `/govuk-frontend/`:


This is no longer correct so I think we need to change this to something like:

When configuring Nunjucks views, remove any references to the node_modules/govuk-frontend/components directory.

People's configuration file will look like

nunjucks.configure([ 'path/to/their/views', 'node_modules/govuk-frontend', // Used for the template.njk 'node_modules/govuk-frontend/components' // Used for components ])

And now need to be:

nunjucks.configure([ 'path/to/their/views', 'node_modules/govuk-frontend' // Used for the everything ])

Add v3.0.0 release note to changelog

f82fedb

Add the edited version of the v3.0.0 release note to CHANGELOG.md.

m-green requested review from 36degrees, NickColley, aliuk2012 and hannalaakso July 12, 2019 10:34

govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1492 July 12, 2019 10:34 Inactive

NickColley reviewed Jul 12, 2019

View reviewed changes

CHANGELOG.md

@@ -2,510 +2,321 @@

## Unreleased 3.0.0 (Breaking release)

Copy link

Contributor

NickColley Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do a link check...

NickColley added this to the v3.0.0 milestone Jul 12, 2019

hannalaakso reviewed Jul 15, 2019

View reviewed changes

36degrees reviewed Jul 16, 2019

View reviewed changes

36degrees approved these changes Jul 16, 2019

View reviewed changes

aliuk2012 approved these changes Jul 16, 2019

View reviewed changes

Changes from review

217e12a

govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1492 July 17, 2019 13:25 Inactive

NickColley reviewed Jul 17, 2019

View reviewed changes

Minor tweak to updating paths

3b0dbb5

govuk-design-system-ci deployed to govuk-frontend-review-pr-1492 July 17, 2019 13:46 View deployment

m-green changed the title ~~Add v3.0.0 release note to changelog~~ Update with edited version of v3.0.0 (unreleased) changelog Jul 17, 2019

m-green merged commit b4bfe29 into master Jul 17, 2019

NickColley deleted the v3-changelog branch July 17, 2019 14:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update with edited version of v3.0.0 (unreleased) changelog #1492

Update with edited version of v3.0.0 (unreleased) changelog #1492

m-green commented Jul 12, 2019 •

edited

Loading

NickColley Jul 12, 2019

NickColley Jul 12, 2019

hannalaakso left a comment

hannalaakso Jul 15, 2019

hannalaakso Jul 15, 2019

m-green Jul 17, 2019 •

edited

Loading

hannalaakso Jul 15, 2019

m-green Jul 17, 2019

hannalaakso Jul 15, 2019 •

edited

Loading

36degrees Jul 16, 2019

m-green Jul 17, 2019 •

edited

Loading

hannalaakso Jul 15, 2019

m-green Jul 17, 2019

36degrees Jul 16, 2019

NickColley Jul 17, 2019

NickColley Jul 17, 2019


		- Ensure GOV.UK Frontend component selectors cannot conflict when initialised
		If you're using HTML or custom JavaScript, change:


		Fixes issues with govuk-fronted javascript clashing with govuk-template/govuk-element and potentially other third-party javascript libraries using `js-` class names as hooks.
		#### If you’re using Sass


		- Spacing of tabs list updated to be more inline with similar lists on GOV.UK and the Design System
		#### If you’re using Javascript


		If you are using HTML, you will need to add the `govuk-` prefix to any `[data-module]` attributes.
		1. Change your `nunjucks.configure` property so it only includes the `node_modules/govuk-frontend/` directory:


		- Fix issue where link underlines sit too low in Firefox
		If you're using HTML, add the SVG code from the [start button example in the Design System](https://design-system.service.gov.uk/components/button/#start-buttons).

Update with edited version of v3.0.0 (unreleased) changelog #1492

Update with edited version of v3.0.0 (unreleased) changelog #1492

Conversation

m-green commented Jul 12, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hannalaakso left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-green Jul 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hannalaakso Jul 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-green Jul 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-green commented Jul 12, 2019 •

edited

Loading

m-green Jul 17, 2019 •

edited

Loading

hannalaakso Jul 15, 2019 •

edited

Loading

m-green Jul 17, 2019 •

edited

Loading