Use generic div element for tabspanel #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1746
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1746
hannalaakso
approved these changes
Feb 26, 2020
Sections when they have an accessible name create landmarks. > The use of region landmarks should be limited, as too many landmarks can dilute their usefulness in quickly navigating to important areas of a page. If you find there are many landmarks, especially generic regions existing in a single page, then the page’s structure should be reexamined. - https://www.scottohara.me/blog/2018/03/03/landmarks.html Also, when the component has not be enhanced these sections do not have accessible names so it means they are the equivalent of a div already. When they're enhanced they're given a role of tabpanel, so they're no longer a section. Given this I'm not sure it was ever useful and by making them generic divs we can avoid HTML validators warning about this component. Closes #1339
NickColley
force-pushed
the
tabs-use-divs-instead-of-sections
branch
from
72068e3
to
0ddb915
Compare
|
As I remember, on the initial implementation of tabs component a (potentially visually hidden) heading was meant to be automatically generated for each section acting as identifier (as exemplified in the Design System) – hence passing the HTML validation. |
Merged
andymantell
added a commit
to surevine/govuk-react-jsx
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sections when they have an accessible name create landmarks.
Also, when the component has not be enhanced these sections do not have
accessible names so it means they are the equivalent of a div already.
When they're enhanced they're given a role of tabpanel, so they're no
longer a section.
Given this I'm not sure it was ever useful and by making them generic
divs we can avoid HTML validators warning about this component.
Closes #1339