Don’t copy *.js files into govuk-esm
#2876
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2876
tasks/gulp/copy-to-destination.js
Outdated
| @@ -15,54 +15,61 @@ const taskArguments = require('../task-arguments') | |||
|
|
|||
| gulp.task('copy-files', () => { | |||
| return merge( | |||
| // Copy source JavaScript | |||
There was a problem hiding this comment.
| // Copy source JavaScript | |
| // Copy ESM files to make them available in the package |
There was a problem hiding this comment.
Can I suggest a tweak to align with the Gulpfile task?
Line 28 in 542e7ec
At the moment we use --destination to choose ./package so the destination could vary
| // Copy source JavaScript | |
| // Copy ESM JavaScript to destination, ready for publishing |
There was a problem hiding this comment.
Thanks @romaricpascal
I've added a new commit with better comments for all these lines (and more!)
tasks/gulp/copy-to-destination.js
Outdated
| // https://github.com/alphagov/govuk-frontend/tree/main/package#readme | ||
| `!${configPaths.src}README.md`, | ||
|
|
||
| // Exclude files from other streams |
There was a problem hiding this comment.
| // Exclude files from other streams | |
| // Exclude files from other streams (MJS and test files are already excluded a bit above) |
There was a problem hiding this comment.
@romaricpascal This one definitely needed a better comment
It was actually excluding files handled by the PostCSS and JSON (from YAML) streams a bit below
Hopefully this is clearer:
// Exclude Sass files handled by PostCSS stream below
`!${configPaths.src}**/*.scss`,
// Exclude source YAML handled by JSON streams below
`!${configPaths.components}**/*.yaml`
colinrotherham
force-pushed
the
source-javascript-copy
branch
from
4d16bb6 to
79ae895
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2876
Thanks, see what you think now |
|
This PR was related to #2243 |
In response to comment regarding *.js files in
govuk-esmThis PR includes:
js:copy-esmtask →copy-files${configPaths.src}**/*.jsglob so only *.mjs are copied