Fix Jest setup/teardown for test server awaiting SIGTERM
#2880
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2880
colinrotherham
force-pushed
the
fix-jest-watch
branch
from
5679937 to
9010d5a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2880
colinrotherham
force-pushed
the
fix-jest-watch
branch
from
9010d5a to
9b9241e
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2880
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2880
There was a problem hiding this comment.
Morning @romaricpascal this PR is now ready for review again
| @@ -1,6 +1,6 @@ | |||
| module.exports = { | |||
| browserContext: 'incognito', | |||
| dumpio: true, | |||
There was a problem hiding this comment.
I've taken this out as it's supposed to be in launch so wasn't working. Can be useful for debugging but adds a lot of noise
config/jest/server/start.mjs
Outdated
| // Server already running? Wait for exit | ||
| if (servers.some(({ signalCode }) => signalCode === 'SIGTERM')) { | ||
| await serverStop() | ||
| timeout = 0 |
There was a problem hiding this comment.
We don't need to wait for the port to open when we know it's just closed
There was a problem hiding this comment.
That's probably worth putting a reminder in the code for the future
| timeout = 0 | |
| // We don't need to wait for the port to open when we know it's just closed | |
| timeout = 0 |
There was a problem hiding this comment.
I've put the comments together like this:
await serverStop() // Wait for server to stop
timeout = 0 // No need to wait for start| await serverStart() // Wait for web server | ||
| await setup() // Open browser | ||
| await setup(jestConfig) // Open browser |
There was a problem hiding this comment.
This enables Jest to open multiple Chrome pages, one per worker
| @@ -59,8 +59,8 @@ describe('/components/button', () => { | |||
| * | |||
| * Examples don't do this and we need it to have something to submit | |||
| */ | |||
| async function trackClicks () { | |||
| page.evaluate(() => { | |||
| function trackClicks (page) { | |||
There was a problem hiding this comment.
With (potentially) multiple pages or tabs open at once, we need to pass in which one we use
config/jest/server/start.mjs
Outdated
| // Server already running? Wait for exit | ||
| if (servers.some(({ signalCode }) => signalCode === 'SIGTERM')) { | ||
| await serverStop() | ||
| timeout = 0 |
There was a problem hiding this comment.
That's probably worth putting a reminder in the code for the future
| timeout = 0 | |
| // We don't need to wait for the port to open when we know it's just closed | |
| timeout = 0 |
colinrotherham
force-pushed
the
fix-jest-watch
branch
from
b8ca5c5 to
7a08cbb
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2880
This PR fixes an issue with Jest in watch mode:
npx jest --watch src/govuk/components/button/button.test.jsWhen watching JavaScript component tests project files the array returned via
getServers()from jest-dev-server appears to list processes that have terminated (or are currently awaiting termination).We should check for
signalCode: 'SIGTERM'processes before assuming the test site is running