Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack example: Remove IE8 support #3390

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Webpack example: Remove IE8 support #3390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions docs/examples/webpack/assets/stylesheets/app-ie8.scss
View file
Open in desktop

This file was deleted.

10 changes: 1 addition & 9 deletions docs/examples/webpack/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,7 @@
<meta name="theme-color" content="#0b0c0c">
<meta http-equiv="X-UA-Compatible" content="IE=edge">

<!--[if !IE 8]><!-->
<link rel="stylesheet" href="/assets/stylesheets/app.min.css">
<!--<![endif]-->
<!--[if IE 8]>
<link rel="stylesheet" href="/assets/stylesheets/app-ie8.min.css">
<![endif]-->
<!--[if lt IE 9]>
<script src="/assets/javascripts/html5shiv.min.js"></script>
<![endif]-->
<link rel="stylesheet" href="/assets/stylesheets/app.min.css">
</head>
<body class="govuk-template__body">
<script>document.body.className = ((document.body.className) ? document.body.className + ' js-enabled' : 'js-enabled');</script>
Expand Down
1 change: 0 additions & 1 deletion docs/examples/webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"@babel/preset-env": "^7.20.2",
"babel-loader": "^9.1.2",
"copy-webpack-plugin": "^11.0.0",
"html5shiv": "^3.7.3",
"postcss-loader": "^7.0.2",
"sass-embedded": "^1.58.3",
"sass-loader": "^13.2.0",
Expand Down
10 changes: 1 addition & 9 deletions docs/examples/webpack/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const TerserPlugin = require('terser-webpack-plugin')

// Module resolution
const frontendPath = dirname(require.resolve('govuk-frontend'))
const html5shivPath = dirname(require.resolve('html5shiv'))

module.exports = ({ WEBPACK_SERVE }, { mode }) => ({
devServer: {
Expand All @@ -20,8 +19,7 @@ module.exports = ({ WEBPACK_SERVE }, { mode }) => ({

entry: [
'./assets/javascripts/main.mjs',
'./assets/stylesheets/app.scss',
'./assets/stylesheets/app-ie8.scss'
'./assets/stylesheets/app.scss'
],

module: {
Expand Down Expand Up @@ -68,7 +66,6 @@ module.exports = ({ WEBPACK_SERVE }, { mode }) => ({

// Compatibility workarounds
ecma: 5,
ie8: true,
safari10: true
}
})]
Expand All @@ -90,11 +87,6 @@ module.exports = ({ WEBPACK_SERVE }, { mode }) => ({
context: resolve(frontendPath, './assets'),
from: '{fonts,images}/**',
to: './assets'
},
{
context: html5shivPath,
from: 'html5shiv.min.js',
to: './assets/javascripts'
}
]
})
Expand Down
2 changes: 0 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.