-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IE11 vendor polyfills #3720
Conversation
Gzipped size of minified JS file: Before: 9.3kB A few thoughts: Intl APIThere's some mentions of IE11 in the i18n's check for Plural Rules and Number Format support. Can we simplify these checks to just look for edit: see #2621 (comment) Bits and bobsThere's a coupla things that come up when searching for "IE" (stuff like IE rendering in the template, potentially some html-validate rules, some specific fixes for components, etc. Not sure we have anywhere to start logging these things to tackle as we go about the work of updating things? DocumentationShould we just remove the polyfilling sections of our documentation? |
Comment about non-vendored polyfills here: #2621 (comment) |
I find browsersl.ist really useful for looking at the intersection of support for these features and ES6 modules. For example, here's the browsers that support ES6 modules but don't support Intl.PluralRules. Because that list isn't empty, we probably do need to keep the checks around for now. However, we do have an issue to remove the fallback 'polyfill' in a future 5.x release – we'll still need to keep the checks, but we can just fall back to the 'other' translation in the few older browsers that don't support it.
These are great catches! I reckon add comments to #2621 for now, like you have already for the various JS APIs? They seem unrelated to the polyfill changes in this PR. |
@colinrotherham I've updated polyfilling documentation and linked to #3722 |
Nice, thanks @domoscargin. Keeps the |
Partially addresses #2506