Watch for changes to assets #3910
Conversation
|
Thanks @36degrees this is brilliant 🎉 For context, we spotted a list of things we didn't watch in this PR: But last week we added Gulp |
| task.name('copy:assets watch', () => | ||
| gulp.watch([ | ||
| `${slash(options.srcPath)}/govuk/assets/` | ||
| ], assets(options)) |
There was a problem hiding this comment.
Not for this PR, but we might want to remove unlink (delete) events from our watchers
| ], assets(options)) | |
| ], { events: ['add', 'change'] }, assets(options)) |
There was a problem hiding this comment.
I had noticed that when deleting a file from src it wasn't deleted from package, presumably because we're only running copy:files and not clean.
Removing the unlink wouldn't fix that but would prevent running the task when a file's deleted when it's not going to do anything anyway?
There was a problem hiding this comment.
Yeah good point, it would only stop early triggering of tasks really—but might free up some "polling" CPU time for all our Windows users too?
Would be a separate issue to synchronise directories fully
Watch the `govuk/assets` folder and re-run the assets task when there are changes. This means that changes to the assets folder are applied to the dist folder (and therefore are reflected in the review app) without having to manually run the `build:package` task.
| @@ -16,19 +16,12 @@ export default (options) => gulp.series( | |||
| files.clean('*', options) | |||
| ), | |||
|
|
|||
| assets(options), | |||
There was a problem hiding this comment.
Should we share this new task with release.mjs too?
It's mostly identical between package.mjs and release.mjs
Would just need destPath overriding without the govuk/ prefix
There was a problem hiding this comment.
Will leave this as a future improvement if that's alright.
Watch for changes to assets
I was taking a look at #3873 and noticed that changes to assets were not reflected in the review app unless I manually ran
npm run build:package.Watch the
govuk/assetsfolder and re-run the assets task when there are changes.This means that changes to the assets folder are applied to the dist folder (and therefore are reflected in the review app) without having to manually run the
build:packagetask.