Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ‘details polyfill’ example from review app #4446

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

36degrees
Copy link
Contributor

This example was used to test the JavaScript polyfill for the details component on a <div> to ensure that it added the same functionality as the native <details> element.

We removed that JavaScript polyfill in #3766.

This example no longer functions correctly (it renders something that looks like the details component, but clicking the summary does not open or close) and serves no purpose, so we can remove it.

This example was used to test the JavaScript polyfill for the details component on a `<div>` to ensure that it added the same functionality as the native `<details>` element.

We removed that JavaScript polyfill in #3766.

This example no longer functions correctly (it renders something that looks like the details component, but clicking the summary does not open or close) and serves no purpose, so we can remove it.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4446 November 9, 2023 11:42 Inactive
Copy link

github-actions bot commented Nov 9, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-5.0.0-beta.1.min.css 114 KiB
dist/govuk-frontend-5.0.0-beta.1.min.js 37.93 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 77.02 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 72.35 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.8 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.53 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 37.94 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.3 KiB

Modules

File Size
all.mjs 68.67 KiB
components/accordion/accordion.mjs 21.37 KiB
components/button/button.mjs 4.48 KiB
components/character-count/character-count.mjs 20.78 KiB
components/checkboxes/checkboxes.mjs 5.61 KiB
components/error-summary/error-summary.mjs 5.79 KiB
components/exit-this-page/exit-this-page.mjs 15.79 KiB
components/header/header.mjs 3.68 KiB
components/notification-banner/notification-banner.mjs 4.32 KiB
components/radios/radios.mjs 4.6 KiB
components/skip-link/skip-link.mjs 3.6 KiB
components/tabs/tabs.mjs 9.33 KiB

View stats and visualisations on the review app


Action run for 9ae5fe1

Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@36degrees 36degrees merged commit 545fde1 into main Nov 9, 2023
@36degrees 36degrees deleted the delete-details-polyfill-example branch November 9, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants