Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changelog updates for consistency #4943

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

querkmachine
Copy link
Member

Some of these were noticed during the 5.3.1 release process. The others are bits that I noticed of my own accord.

Changes

  • Adds a changelog entry for Remove duplicate errorMessage argument for the password input component #4942.
  • Adds the missing npm installation instructions to the 5.3.0 and 5.3.1 releases.
  • Changes the heading for the 5.3.0 release to be consistent with previous releases: changed from GOV.UK Frontend v5.3.0 (Feature release) to 5.3.0 (Feature release).
  • Fixes inconsistent capitalisation of Feature release and Fix release in multiple headings.

Thoughts

I noticed that 5.0.0 and 5.2.0 included opening paragraphs providing an overview of the changes in that version, but 5.1.0 and 5.3.0 onwards do not. Is this something we want to keep having or is it additional to requirements?

@querkmachine querkmachine self-assigned this Apr 19, 2024
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4943 April 19, 2024 13:10 Inactive
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.24 KiB
dist/govuk-frontend-development.min.js 42.21 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 87.21 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 81.95 KiB
packages/govuk-frontend/dist/govuk/all.mjs 4.17 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.23 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.2 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 77.67 KiB 40.19 KiB
accordion.mjs 22.71 KiB 12.85 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for d428a91

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Should we update the releases themselves as well?

Re: us not including a description at the beginning of 5.3.1 and 5.3.0, I think the frank reason is that this was just missed. Probably we need to make a call on this and document it somewhere. It's certainly something we should be conscious of if we think we'll be doing more little releases with less effort required from tech writers.

@querkmachine querkmachine merged commit fb5afe0 into main Apr 19, 2024
46 checks passed
@querkmachine querkmachine deleted the changelog-updates branch April 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants