Remove toolkit and template dependency #48
Conversation
kr8n3r
commented
May 31, 2018
•
kr8n3r
commented
- Updates layouts so they use the bollerplate template from GOV.UK Frontend
- Implements Footer component from GOV.UK Frontend
- Implements Header component from GOV.UK Frontend
- Reimplements missing unbranded template things and fixes: Unbranded css/scss missing #41
- Removes references to Frontend toolkit and Template
- Updates server.js
app/views/layout.html
Outdated
| {% from "./components/error-message/macro.njk" import govukErrorMessage %} | ||
| {% from "./components/error-summary/macro.njk" import govukErrorSummary %} | ||
| {% from "./components/fieldset/macro.njk" import govukFieldset %} | ||
| {% from "./components/file-upload/macro.njk" import govukFileUpload %} |
There was a problem hiding this comment.
I think this list is out of date now
kr8n3r
force-pushed
the
remove-toolkit-and-template-dependency
branch
6 times, most recently
from
a0f536a
to
9c46d71
Compare
kr8n3r
changed the title
kr8n3r
force-pushed
the
remove-toolkit-and-template-dependency
branch
4 times, most recently
from
3695ca3
to
4e68340
Compare
There was a problem hiding this comment.
A lot of good clean up in this PR 💯. I'll leave it for others to review too, but I'm happy to approve it.
I guess we don't need lib/govuk_template.html L9 in .gitignore anymore.
server.js
Outdated
| path.join(__dirname, '/lib/'), | ||
| path.join(__dirname, '/node_modules/@govuk-frontend/frontend/components')] | ||
| path.join(__dirname, '/node_modules/@govuk-frontend/frontend'), // template path | ||
| path.join(__dirname, '/node_modules/@govuk-frontend/frontend/components') |
There was a problem hiding this comment.
If we add only /node_modules/@govuk-frontend/frontend means we'll have to add /components to each component import. Not sure what's best.
There was a problem hiding this comment.
yeah thought about that, but then in the DS the import statement says
{% from "file-upload/macro.njk" import govukFileUpload %}
if they copied that in it wouldn't work if we specify
'/node_modules/@govuk-frontend/frontend' path only
docs/views/layout_unbranded.html
Outdated
| @@ -1,9 +1,13 @@ | |||
| {% extends "govuk_template_unbranded.html" %} | |||
| {% extends "template_unbranded.html" %} | |||
There was a problem hiding this comment.
Should we change the extension of template_unbranded.html to .njk since it has Nunjucks syntax inside
kr8n3r
force-pushed
the
remove-toolkit-and-template-dependency
branch
2 times, most recently
from
a5ea818
to
bbd060c
Compare
|
updated with comments |
kr8n3r
force-pushed
the
remove-toolkit-and-template-dependency
branch
2 times, most recently
from
38b349a
to
7992b29
Compare
kr8n3r
force-pushed
the
remove-toolkit-and-template-dependency
branch
from
7992b29
to
074dee2
Compare
kr8n3r
force-pushed
the
remove-toolkit-and-template-dependency
branch
from
074dee2
to
19cbd4f
Compare
