Fix tests

alphagov · Mar 20, 2023 · d72d00a · d72d00a
1 parent 325fe2e
commit d72d00a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/migrator/migration-steps.js b/migrator/migration-steps.js
@@ -245,6 +245,7 @@ async function upgradeIfPossible (filePath, matchFound) {
   if (matchFound) {
     return true
   } else {
+    const reporter = await addReporter(`Update ${filePath}`)
     const fullPath = path.join(projectDir, filePath)
     const filename = fullPath.split(path.sep).pop()
     if (filename === 'application.js') {
@@ -279,9 +280,11 @@ if (window.console && window.console.info) {
           return currentContent.replace(originalText, replacementText || '')
         }, fileBuffer.toString())
         await fsp.writeFile(fullPath, content)
+        await reporter(true)
         return true
       }
     }
+    await reporter(false)
     return false
   }
 }

diff --git a/migrator/migration-steps.spec.js b/migrator/migration-steps.spec.js
@@ -367,7 +367,10 @@ $(document).ready(function () {
 `//
 // For guidance on how to add JavaScript see:
 // https://prototype-kit.service.gov.uk/docs/adding-css-javascript-and-images
-//···
+//
+
+
+
 window.GOVUKPrototypeKit.documentReady(() => {
   // Add JavaScript here
   console.log('Hello')
@@ -390,7 +393,7 @@ window.GOVUKPrototypeKit.documentReady(() => {
     expect(actualFileContent).toEqual(expectedFileContents)
 
     expect(reporter.addReporter).toHaveBeenCalledTimes(1)
-    expect(reporter.addReporter).toHaveBeenCalledWith(`Overwrite ${applicationJsFile}`)
+    expect(reporter.addReporter).toHaveBeenCalledWith(`Update ${applicationJsFile}`)
 
     expect(mockReporter).toHaveBeenCalledTimes(1)
     expect(mockReporter).toHaveBeenCalledWith(true)