Fix link text for anchor links to GDS Way pages #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1024
Commit 8d52920 updated the URL for links to style guides that had been moved to the GDS Way. In doing so the links now violate the rule that anchor links should not be used without explaining that the link goes into a page [1]. This commit updates the link text so that it is clear that the links take you to a place within a page. [1]: https://docs.google.com/document/d/1XY8RG2uQjQNo7PFhtjvqIcHqGqSgGDRuQGkpOFpc6iM/preview Co-authored-by: Eoin Shaughnessy <eoin.shaughnessy@digital.cabinet-office.gov.uk>
lfdebrux
force-pushed
the
ldeb-fix-anchor-link-content
branch
from
86ba450
to
fde89db
Compare
Thanks :) |
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1024
EoinShaughnessy
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8d52920 updated the URL for links to style guides that had been moved to the GDS Way. In doing so the links now violate the rule that anchor links should not be used without explaining that the link goes into a page 1.
This commit updates the link text so that it is clear that the links take you to a place within a page.