Run Gulp using the Node executable to fix permissions problem on GDS managed devices #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1039
|
@joelanman Has this been tested on a locked down machine? |
|
@lfdebrux not yet, sorry should have made that clear, will change this to a draft PR. It should work, given the executable is node |
|
Commit f6f7638 can probably be removed from this PR. |
This was referenced Jun 30, 2021
Closed
|
This has also been manually tested on a GDS managed device, and a non GDS managed linux and windows device |
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1039
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1039
joelanman
changed the title
some machines do not have permission to run gulp directly
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1039
lfdebrux
approved these changes
Jul 12, 2021
|
we tested this on another windows device (now a total of 2) as the automated testing does not cover this. |
joelanman
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run gulp using the node executable
GDS Managed devices cannot run anything that isn't installed via Self Service. This change runs node to run gulp indirectly so does not need permissions.