Update to Node.js v14.17.6 when using Node Version Manager #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1076
lfdebrux
force-pushed
the
ldeb-bump-node
branch
from
2dfb05c
to
dca12bd
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1076
vanitabarrett
approved these changes
Sep 9, 2021
lfdebrux
changed the title
lfdebrux
changed the title
We want to make sure our users are using a secure version of npm. This commit bumps default Node.js version specified by `.nvmrc` to the latest Node 14 version. This includes the latest version of npm, which is patched to close an arbitrary code execution vulnerability. This follows a recommendation by the GitHub security blog [[1]]. [1]: https://github.blog/2021-09-08-github-security-update-vulnerabilities-tar-npmcli-arborist/
lfdebrux
force-pushed
the
ldeb-bump-node
branch
from
dca12bd
to
d74174c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1076
joelanman
approved these changes
Sep 9, 2021
|
@joelanman, agree, I'm thinking about that, I've opened a separate issue where we can discuss this further: #1077 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure our users are using a secure version of npm. This commit bumps default Node.js version specified by
.nvmrcto the latest Node 14 version. This includes the latest version of npm, which is patched to close an arbitrary code execution vulnerability. This follows a recommendation by the GitHub security blog [1].