Replace back link placeholder URLs with JavaScript #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1103
domoscargin
changed the title
|
looks good! I don't think the hover thing is an issue. Needs an entry in Changelog I think |
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1103
domoscargin
force-pushed
the
bk-javascript-for-backlinks
branch
from
8f106ee
to
1e05b5c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1103
|
Not 100% sure, but you could argue this is a 'new feature' rather than a fix and therefore needs a more extended changelog entry to explain the change to users |
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1103
In most cases, the back button should simply go back to the referring page, so we can use `window.history`.
domoscargin
force-pushed
the
bk-javascript-for-backlinks
branch
from
efde4aa
to
1bf6493
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1103
|
I've added a feature CHANGELOG entry. |
domoscargin
force-pushed
the
bk-javascript-for-backlinks
branch
from
1bf6493
to
55f5f4c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1103
domoscargin
force-pushed
the
bk-javascript-for-backlinks
branch
from
55f5f4c
to
8fd1929
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1103
|
|
||
| ## New features | ||
|
|
||
| ### Replace back link placeholder URLs with javascript |
There was a problem hiding this comment.
Suggested change
| ### Replace back link placeholder URLs with javascript | |
| ### Replace back link placeholder URLs with JavaScript |
|
|
||
| ### Replace back link placeholder URLs with javascript | ||
|
|
||
| Previously, users had to manually replace the `href` for each back link in the page templates. |
There was a problem hiding this comment.
Suggested change
| Previously, users had to manually replace the `href` for each back link in the page templates. | |
| You can now use JavaScript to make the [back link component]( https://design-system.service.gov.uk/components/back-link/) take users to the previous page by default. |
|
|
||
| Previously, users had to manually replace the `href` for each back link in the page templates. | ||
|
|
||
| Now, we use JavaScript to make the back link take you to the previous page by default. |
There was a problem hiding this comment.
Suggested change
| Now, we use JavaScript to make the back link take you to the previous page by default. | |
| Before, you had to manually replace the `href` attribute for each back link in the page templates. |
|
|
||
| Now, we use JavaScript to make the back link take you to the previous page by default. | ||
|
|
||
| This approach is not appropriate for production scenarios, where you cannot rely on JavaScript being available at all times. |
There was a problem hiding this comment.
Suggested change
| This approach is not appropriate for production scenarios, where you cannot rely on JavaScript being available at all times. | |
| Do not use this approach for production scenarios, where you cannot rely on JavaScript always being available. |
|
|
||
| This approach is not appropriate for production scenarios, where you cannot rely on JavaScript being available at all times. | ||
|
|
||
| You can still override the `href` attribute if you need different behaviour. |
There was a problem hiding this comment.
Worth giving an example of different behaviour? Or would that be overkill?
vanitabarrett
approved these changes
Oct 4, 2021
|
After a chat with @EoinShaughnessy, we've decided it'll be easier for the 2i reviewer if all changelog/release note changes are in one PR. So we're going to merge this as-is and incorporate the suggested release note changes into a separate PR with the other changelog changes. |
EoinShaughnessy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases, the back button should simply go back to the referring page, so we can use
window.history.Closes #494
There is a small potential issue when hovering on the link, as browsers will display the
hrefproperty in the status bar, which in this case is just some javascript (as shown in the image below).I'm not sure how much of an issue this is for prototyping.