Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visually hidden footer title #1104

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

domoscargin
Copy link
Contributor

"Support links" isn't very clear. "Footer links" is a bit more agnostic.

Fixes #1102

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1104 September 30, 2021 11:27 Inactive
@domoscargin domoscargin changed the title Change hidden footer title Change visually hidden footer title Sep 30, 2021
@joelanman
Copy link
Contributor

looks good thanks! Wondering if this needs to be in changelog or not... we dont normally add to changelog if it only affects the documentation site, but I think this affects both documentation site and prototypes, so yeh I think we should?

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1104 September 30, 2021 12:34 Inactive
@EoinShaughnessy
Copy link
Contributor

@joelanman Yeah, agreed re updating Changelog

Copy link
Contributor

@joelanman joelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The heading "Support links" isn't clear
4 participants