-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve query string when redirecting POSTs to GETs #1120
Preserve query string when redirecting POSTs to GETs #1120
Conversation
313a33f
to
5f34720
Compare
looks good thanks, just waiting on a review with the rest of the team |
This looks good to me, thanks @edwardhorsford. Do you want to add a feature changelog entry? Happy to do it myself. |
@domoscargin added a changelog entry. Hope the formatting is ok. Do you allow commits to be squashed on merge, or does that need to happen beforehand? |
We generally squash beforehand. |
69dbdf8
to
ad8d78d
Compare
@domoscargin well I borked that. Rather than squashing, I seem to have brought in all the intermediary commits on the kit. Can you help? |
4f213f9
to
4005a81
Compare
@edwardhorsford Should be sorted. We're just going to write some documentation for this. |
Thanks both! |
When the kit redirects POSTs to GETs it doesn't preserve any query string in the url. This updates to preserve that.
This means if a query string is included in the form action, when the user is redirected to the resulting GET url, that query string is as it was.
This is useful when:
I added support for this in our service in September last year and it's worked well - you can now use query strings seamlessly and they're preserved regardless of whether you're doing a GET or a POST.