Update to Node 16 and drop support for Node 10 #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1127
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1127
|
as this update required an update of gulp-sass, I think that means we don't need #1073 any more if this is merged |
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1127
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1127
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1127
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1127
lfdebrux
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1127
4 tasks
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1127
domoscargin
reviewed
Nov 2, 2021
The current long term support (LTS) version of Node.js is now v16. This commit updates the documentation to tell users to install Node v16, and also updates the tooling to use Node 16.
gulp-sass v4 does not support Node v16, trying to install it results in compile errors: ``` npm ERR! 1 error generated. npm ERR! make: *** [Release/obj.target/binding/src/binding.o] Error 1 npm ERR! gyp ERR! build error npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2 ``` This commit bumps [gulp-sass](https://github.com/dlmanning/gulp-sass) from 4.0.1 to 5.0.0: - [Release notes](https://github.com/dlmanning/gulp-sass/releases/tag/v5.0.0) - [Changelog](https://github.com/dlmanning/gulp-sass/blob/master/CHANGELOG.md) - [Commits](dlmanning/gulp-sass@v4.0.1...v5.0.0) This version of gulp-sass includes a breaking change that removes `node-sass` as a dependency, so as to be able to support other Sass compilers. This commit therefore moves `node-sass` from being a dev dependency to a normal dependency, as `gulp-sass` is a normal dependency and requires `node-sass` to operate. This commit also changes the import of `gulp-sass` to explicity set it to use Node Sass, using the method suggested by the [migration guide](https://www.npmjs.com/package/gulp-sass#migrating-to-version-5). We also bumps [node-sass](https://github.com/sass/node-sass) from 4.14.1 to 5.0.0: - [Release notes](https://github.com/sass/node-sass/releases/tag/v5.0.0) - [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md) - [Commits](sass/node-sass@v4.14.1...v5.0.0) Both of these major version bump includes a breaking change dropping support for Node.js versions less than 10, so we have to follow suite.
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1127
domoscargin
approved these changes
Nov 2, 2021
This was referenced Nov 2, 2021
Merged
This was referenced Oct 20, 2022
Change guidance to talk about Node 18 when it's released as LTS
alphagov/govuk-prototype-kit-docs#58
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from Node 14 to Node 16.
The current long term support (LTS) version of Node.js is now v16.
This commit updates the documentation to tell users to install Node v16, and also updates the tooling to use Node 16.