Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove express-writer from package file #1133

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Conversation

domoscargin
Copy link
Contributor

We don't use this package anywhere in the codebase, and the app seems to run correctly without it, so it looks like we can remove it entirely.

We don't use this package anywhere in the codebase, and the app seems to run correctly without it, so it looks like we can remove it entirely.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1133 October 29, 2021 11:10 Inactive
@joelanman
Copy link
Contributor

thanks! Can we add to Changelog? I think its a bug fix

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1133 October 29, 2021 11:12 Inactive
Copy link
Contributor

@joelanman joelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@domoscargin domoscargin merged commit bc13e4b into main Oct 29, 2021
@domoscargin domoscargin deleted the bk-remove-express-writer branch October 29, 2021 12:15
@domoscargin domoscargin mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants