Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a package-lock.json file #1143

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Add a package-lock.json file #1143

merged 2 commits into from
Nov 9, 2021

Conversation

domoscargin
Copy link
Contributor

This adds a package-lock file as a temporary measure so that we can receive dependabot alerts.

We still have to figure out how to help users with dependency pinning before the next release, but we've not yet decided the right approach.

This also enables auditing (by removing audit=false from .npmrc) so that we can investigate and fix.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1143 November 9, 2021 10:12 Inactive
@domoscargin
Copy link
Contributor Author

😬

52 vulnerabilities (15 moderate, 35 high, 2 critical)

This adds a package-lock file as a temporary measure so that we can receive dependabot alerts.

We still have to figure out how to help users with dependency pinning before the next release, but we've not yet decided the right approach.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1143 November 9, 2021 10:34 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1143 November 9, 2021 10:39 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1143 November 9, 2021 10:42 Inactive
@domoscargin domoscargin merged commit 5e60a5b into main Nov 9, 2021
@domoscargin domoscargin deleted the bk-add-package-lock branch November 9, 2021 10:48
@joelanman joelanman mentioned this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants