Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the GOV.UK Prototype Kit to use GOV.UK Frontend v4.0.0 #1195

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Conversation

domoscargin
Copy link
Contributor

@domoscargin domoscargin commented Dec 9, 2021

This uses the govuk-frontend v4 pre-release.

I've gone through the CHANGELOG for v4: https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md and there were only a couple of minor things that needed updating.

We can merge this when we have replaced the pre-release with the actual release.

Closes #1063

Summary of findings

  • The kit doesn't have any accordions. The step by step navigation uses its own styles and scripts to function.
  • No use of the govuk-main-wrapper mixins
  • No use of the $govuk-border-width-form-element-error variable
  • The kit does have summary lists, but none of them have an empty actions span
  • The kit doesn't use navigationClasses on the header
  • The kit doesn't include conditionally revealed content (other than on the step by step, which handles that itself)
  • There are no character counts
  • The kit doesn't import individual JavaScript modules
  • The kit has no error message spans
  • The kit had some hint spans which have been updated
  • No uses of the Sass iff function
  • No use of govuk-tag--inactive
  • No cookie banner
  • The kit doesn't import individual Sass files from the core or override layers
  • Footer displays correctly
  • The kit had some SVGs with role="presentation" which have now been updated

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 9, 2021 10:22 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 9, 2021 10:33 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 9, 2021 15:01 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 9, 2021 15:08 Inactive
@lfdebrux
Copy link
Member

lfdebrux commented Dec 10, 2021

Thanks for being explicit and listing out the things you checked!

I think this was added to the release since you looked at it, but I checked and we're using the Nunjucks macro for the skip link, so we don't have to do anything to include JavaScript for the skip link.

@lfdebrux
Copy link
Member

I also checked that we don't use HTML date inputs anywhere, so we don't need to worry about changing date input from type="number" to inputmode="numeric".

@NoraGDS NoraGDS changed the title Update the kit to use GOV.UK Frontend v4 Update the GOV.UK Prototype Kit it to use GOV.UK Frontend v4 Dec 13, 2021
@NoraGDS NoraGDS changed the title Update the GOV.UK Prototype Kit it to use GOV.UK Frontend v4 Update the GOV.UK Prototype Kit it to use GOV.UK Frontend v4.0.0 Dec 13, 2021
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 13, 2021 12:04 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 13, 2021 12:25 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 15, 2021 08:56 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 15, 2021 10:07 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 15, 2021 10:08 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 15, 2021 14:43 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 16, 2021 09:14 Inactive
@domoscargin domoscargin marked this pull request as ready for review December 16, 2021 09:15
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 16, 2021 09:15 Inactive
@domoscargin domoscargin changed the title Update the GOV.UK Prototype Kit it to use GOV.UK Frontend v4.0.0 Update the GOV.UK Prototype Kit to use GOV.UK Frontend v4.0.0 Dec 16, 2021
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few docs related suggestions, but otherwise the changes look sensible to me.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
docs/documentation/updating-the-kit.md Outdated Show resolved Hide resolved
docs/documentation/updating-the-kit.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 16, 2021 09:27 Inactive
Update Prototype Kit CHANGELOG with release notes for v12.0.0
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 16, 2021 09:35 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1195 December 16, 2021 09:37 Inactive
@domoscargin domoscargin merged commit a07f34a into main Dec 16, 2021
@domoscargin domoscargin mentioned this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Prototype Kit to use GOV.UK Frontend v4.0.0
5 participants