-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the GOV.UK Prototype Kit to use GOV.UK Frontend v4.0.0 #1195
Conversation
Thanks for being explicit and listing out the things you checked! I think this was added to the release since you looked at it, but I checked and we're using the Nunjucks macro for the skip link, so we don't have to do anything to include JavaScript for the skip link. |
I also checked that we don't use HTML date inputs anywhere, so we don't need to worry about changing date input from |
Following govuk-frontend update guidance: https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md#update-the-html-for-hints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few docs related suggestions, but otherwise the changes look sensible to me.
Update Prototype Kit CHANGELOG with release notes for v12.0.0
This uses the govuk-frontend v4 pre-release.
I've gone through the CHANGELOG for v4: https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md and there were only a couple of minor things that needed updating.
We can merge this when we have replaced the pre-release with the actual release.
Closes #1063
Summary of findings
govuk-main-wrapper
mixins$govuk-border-width-form-element-error
variablenavigationClasses
on the headeriff
functiongovuk-tag--inactive
core
oroverride
layersrole="presentation"
which have now been updated