Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove V6 compatibility #1293

Closed
wants to merge 1 commit into from
Closed

Remove V6 compatibility #1293

wants to merge 1 commit into from

Conversation

joelanman
Copy link
Contributor

@joelanman joelanman commented Apr 14, 2022

Resolves #1295

It adds complexity to the codebase that we no longer need. Removing it makes other work we want to do like removing Gulp easier

To do:

  • Update changelog (this will be a breaking change)
  • Review tests, the update script test touches on v6 but I don't really understand why

Copy link
Contributor

@fofr fofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing this with #1123

I think you need to:

  • remove lib/v6/govuk_template_unbranded.html
  • remove unused dependencies from package.json (and the lock file)

@joelanman joelanman force-pushed the remove-v6-support branch 2 times, most recently from c4c290f to d45d59d Compare April 22, 2022 11:19
@joelanman joelanman marked this pull request as ready for review April 22, 2022 12:29
@joelanman
Copy link
Contributor Author

We may want to consider deprecating this for a period before removing it. This could warn users who use it (however they will have to update to see the warning). I think I'm more in favour of just removing, it's been a long time. Deprecating would add a month or so to this work to have a chance of being an effective warning.

It adds complexity to the codebase that we no longer need
@joelanman
Copy link
Contributor Author

closing in favour of #1432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPIC] Remove v6 support
3 participants