Add tests for gulp functionality #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
BenSurgisonGDS
force-pushed
the
add-tests-for-gulp-functionality
branch
3 times, most recently
from
307bc57
to
abbe1d1
Compare
BenSurgisonGDS
force-pushed
the
add-tests-for-gulp-functionality
branch
2 times, most recently
from
226be8f
to
674594b
Compare
lfdebrux
force-pushed
the
add-tests-for-gulp-functionality
branch
from
070ddaa
to
a916056
Compare
BenSurgisonGDS
force-pushed
the
add-tests-for-gulp-functionality
branch
from
0c61cfe
to
a16c2cf
Compare
lfdebrux
force-pushed
the
add-tests-for-gulp-functionality
branch
3 times, most recently
from
354d03c
to
0a6168b
Compare
BenSurgisonGDS
force-pushed
the
add-tests-for-gulp-functionality
branch
from
8522a43
to
e9c4612
Compare
Currently the prototype kit is flaky on macOS, `gulp.watch` doesn't always pick up changes to the assets folder. We're planning to rip gulp out soon (#1290), so for now we just let them fail, and we should just make sure to fix the flakiness then so we can remove this kludge.
BenSurgisonGDS
force-pushed
the
add-tests-for-gulp-functionality
branch
from
cb83cd8
to
95d67d6
Compare
BenSurgisonGDS
force-pushed
the
add-tests-for-gulp-functionality
branch
from
95d67d6
to
76720fa
Compare
lfdebrux
approved these changes
May 17, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cypress to the CI, build integration tests to test the current gulp functionality with a view to maintain that functionality when gulp is replaced.
See Issue: #1307