Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _unchecked falsey value on check your answers page #1333

Merged
merged 1 commit into from
May 23, 2022
Merged

Fix _unchecked falsey value on check your answers page #1333

merged 1 commit into from
May 23, 2022

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented May 20, 2022 •
edited
Loading

This PR resolves issue: #1215

Changes:

  • Remove all occurrences of "_unchecked" within a checkbox value array
  • Create unit tests to test the above
  • Add additional unit tests to test the rest of the auto store functionality.

@BenSurgisonGDS BenSurgisonGDS self-assigned this May 20, 2022
@BenSurgisonGDS BenSurgisonGDS mentioned this pull request May 20, 2022
Closed
@BenSurgisonGDS BenSurgisonGDS linked an issue May 23, 2022 that may be closed by this pull request
_unchecked falsey value displays on check your answers page #1215
Closed
lfdebrux
lfdebrux approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@lfdebrux lfdebrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!! Especially appreciate the test 👍

@BenSurgisonGDS BenSurgisonGDS merged commit 37ace8f into main May 23, 2022
@BenSurgisonGDS BenSurgisonGDS deleted the fix-_unchecked-falsey-value-on-check-your-answers-page branch May 23, 2022 14:42
@joelanman
Copy link
Contributor

@BenSurgisonGDS nice work, did we agree to fix the front end code too, so it never adds multiple _unchecked? If we still want to do that shall I raise a new issue?

@joelanman
Copy link
Contributor

also this needs a Changelog entry and release notes

@joelanman joelanman mentioned this pull request May 24, 2022
Closed
@lfdebrux
Copy link
Member

@BenSurgisonGDS nice work, did we agree to fix the front end code too, so it never adds multiple _unchecked? If we still want to do that shall I raise a new issue?

@joelanman we were unable to find a bug in our frontend code. Suspect the issue may be in browser. No harm in raising another issue, but I'd suggest it would be low priority.

lfdebrux added a commit that referenced this pull request Jun 7, 2022
@lfdebrux
Update changelog for PR #1333
976c002
lfdebrux added a commit that referenced this pull request Jun 14, 2022
@lfdebrux
Merge pull request #1371 from alphagov/ldeb-add-changelog-1333
cea852a 
Update changelog for PR #1333
@lfdebrux lfdebrux mentioned this pull request Jun 17, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfdebrux lfdebrux lfdebrux approved these changes

@joelanman joelanman Awaiting requested review from joelanman

@nataliecarey nataliecarey Awaiting requested review from nataliecarey

Assignees

@BenSurgisonGDS BenSurgisonGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_unchecked falsey value displays on check your answers page
3 participants
@BenSurgisonGDS @joelanman @lfdebrux