Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update step by step and install it as an extension #1471

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Update step by step and install it as an extension #1471

merged 2 commits into from
Jul 29, 2022

Conversation

joelanman
Copy link
Contributor

@joelanman joelanman commented Jul 19, 2022 •
edited
Loading

closes #1081

This PR:

  • Imports Step by Step Sass and Javascript via an extension
  • Updates the Step by Step templates

Notes and draft guidance for users

To do:

  • Publish Step by step as an npm module (currently its importing from github)
  • I need to credit @domoscargin on the commits but I'm not sure how
  • Document how to keep using the old version of Step by step

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-update-ste-ap1yke July 19, 2022 12:45 Inactive
@joelanman joelanman mentioned this pull request Jul 19, 2022
Closed
3 tasks
@joelanman joelanman marked this pull request as draft July 19, 2022 13:03
@joelanman
Copy link
Contributor Author

draft until we publish step by step on npm, so we can switch package.json over

@joelanman
Copy link
Contributor Author

seems like the step by step tests fail, which is good, @BenSurgisonGDS can you help me fix them?

@BenSurgisonGDS BenSurgisonGDS force-pushed the update-step-by-step-2 branch 2 times, most recently from e59e329 to 7ebd60f Compare July 29, 2022 09:40
@joelanman joelanman changed the title Use step by step as an extension Update step by step and install it as an extension Jul 29, 2022
@joelanman joelanman marked this pull request as ready for review July 29, 2022 10:26
lfdebrux
lfdebrux approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@lfdebrux lfdebrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Let's :shipit:

@joelanman joelanman merged commit b90bd51 into main Jul 29, 2022
@joelanman joelanman deleted the update-step-by-step-2 branch July 29, 2022 12:40
@lfdebrux lfdebrux mentioned this pull request Jul 29, 2022
Merged
@lfdebrux lfdebrux mentioned this pull request Aug 23, 2022
Merged
@lfdebrux lfdebrux mentioned this pull request Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfdebrux lfdebrux lfdebrux approved these changes

@BenSurgisonGDS BenSurgisonGDS Awaiting requested review from BenSurgisonGDS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Step by step pattern is out of date
4 participants
@joelanman @lfdebrux @govuk-design-system-ci @BenSurgisonGDS