Fix page reloads when prototype assets are changed #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-add-w-qhdaoy
lfdebrux
force-pushed
the
ldeb-add-watch-js-test
branch
from
55570a6
to
456f24f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-ldeb-add-w-qhdaoy
BenSurgisonGDS
approved these changes
Jul 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on adding tests for #1481 as suggested by #1481 (comment), I noticed that the kit wasn't behaving as expected; when changing the contents of application.js, the page would not be reloaded.
This PR fixes the nodemon config to restore the expected behaviour, as well as adding the tests.