-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate starter files #1533
Generate starter files #1533
Conversation
89a97c5
to
a80af3b
Compare
dfabdd6
to
4b06bfb
Compare
I think it might be helpful to have a changelog entry detailing all the user facing changes this PR makes, including things like assets no longer being copied to the public folder and which kit code is no longer in the userspace. |
31630c3
to
da3b6da
Compare
Yes, that's correct. I believe these should be in documentation rather than in the kit itself, after v13 we should expect not to make any changes in user space so any templates we provide in the starter kit will fall out of sync and get out of date. I don't know if documentation is the right place for them but I know that providing them in the starter kit will lead us into problems that I'd rather avoid if we can. |
If the review apps are useful to us it would be good to fix them but I think this can happen later. |
9e1318c
to
3bad7bc
Compare
… legacy. v13 will be our first release to npm, some of the old approaches needed to change to accommodate this. Co-authored-by: Laurence de Bruxelles <laurence.debruxelles@digital.cabinet-office.gov.uk> Co-authored-by: Ben Surgison <ben.surgison@digital.cabinet-office.gov.uk>
3bad7bc
to
0c11e60
Compare
See:
This PR makes the kit a package only and all unit, integration and acceptence tests have been changed or removed to suit.
Please note that the templates in the cypress tests will be cut down in a future ticket to only contain the content and structure being tested.