Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate starter files #1533

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Generate starter files #1533

merged 1 commit into from
Aug 23, 2022

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Aug 16, 2022

See:

This PR makes the kit a package only and all unit, integration and acceptence tests have been changed or removed to suit.

Please note that the templates in the cypress tests will be cut down in a future ticket to only contain the content and structure being tested.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 16, 2022 10:17 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 16, 2022 10:24 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 16, 2022 11:56 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 16, 2022 14:07 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 16, 2022 15:50 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 16, 2022 15:54 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 16, 2022 16:11 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 16, 2022 22:20 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 08:41 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 08:45 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 09:14 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 09:18 Inactive
@BenSurgisonGDS BenSurgisonGDS marked this pull request as ready for review August 17, 2022 09:30
@BenSurgisonGDS BenSurgisonGDS requested review from a team, lfdebrux and nataliecarey and removed request for a team August 17, 2022 09:30
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 09:33 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 09:38 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 09:53 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 10:00 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 10:05 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 10:07 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 10:11 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 11:57 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 13:02 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 14:32 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 17, 2022 16:09 Inactive
@lfdebrux
Copy link
Member

I think it might be helpful to have a changelog entry detailing all the user facing changes this PR makes, including things like assets no longer being copied to the public folder and which kit code is no longer in the userspace.

listen-on-port.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
server.js Outdated Show resolved Hide resolved
server.js Show resolved Hide resolved
server.js Outdated Show resolved Hide resolved
server.js Outdated Show resolved Hide resolved
lib/build/tasks.js Show resolved Hide resolved
server.js Outdated Show resolved Hide resolved
server.js Outdated Show resolved Hide resolved
scripts/cli Show resolved Hide resolved
scripts/cli Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 19, 2022 15:11 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 22, 2022 14:19 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 22, 2022 14:38 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 22, 2022 15:16 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 23, 2022 08:16 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 23, 2022 09:18 Inactive
@nataliecarey nataliecarey changed the base branch from main to v13 August 23, 2022 09:24
@nataliecarey
Copy link
Contributor

In commit 21aefc0 (Generate starter files) we don't move the files from docs/views/templates to the prototype-starter folder, is this correct? Do we not want to include these templates with the prototype starter?

Yes, that's correct. I believe these should be in documentation rather than in the kit itself, after v13 we should expect not to make any changes in user space so any templates we provide in the starter kit will fall out of sync and get out of date.

I don't know if documentation is the right place for them but I know that providing them in the starter kit will lead us into problems that I'd rather avoid if we can.

@nataliecarey
Copy link
Contributor

The changes to the project structure breaks our ability to deploy review apps automatically, is that an issue we want to fix, or shall we just turn off review apps for this repo?

If the review apps are useful to us it would be good to fix them but I think this can happen later.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 23, 2022 10:03 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 23, 2022 10:08 Inactive
… legacy.

v13 will be our first release to npm, some of the old approaches needed to change to accommodate this.

Co-authored-by: Laurence de Bruxelles <laurence.debruxelles@digital.cabinet-office.gov.uk>
Co-authored-by: Ben Surgison <ben.surgison@digital.cabinet-office.gov.uk>
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-generate-s-4pfdwd August 23, 2022 14:40 Inactive
@nataliecarey nataliecarey merged commit daa2cb2 into v13 Aug 23, 2022
@nataliecarey nataliecarey deleted the generate-starter-files branch August 23, 2022 15:00
@lfdebrux lfdebrux mentioned this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants