Setup router api #1572
Merged
Setup router api #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-protot-setup-rout-frgzph
… Updated filters to match the API changes.
nataliecarey
force-pushed
the
setup-router-api
branch
from
73427af
to
f173fca
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-setup-rout-frgzph
govuk-design-system-ci
temporarily deployed
to
govuk-protot-setup-rout-frgzph
|
I think we can do better with the name of |
5 tasks
|
@natcarey changes make sense to me, would you mind updating the changelog in this PR? |
nataliecarey
force-pushed
the
setup-router-api
branch
from
96363e7
to
6c315bf
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-setup-rout-frgzph
joelanman
reviewed
Sep 2, 2022
CHANGELOG.md
Outdated
| @@ -12,7 +12,7 @@ | |||
| - Assets and Javascript are served from their location in the app folder rather than being copied to a public folder | |||
| - Generated assets are all inside .tmp | |||
| - The core prototype-kit files have been moved into the package | |||
| - The start script uses the new govuk-prototype-kit cli | |||
| - The start script uses the new uk-prototype-kit cli | |||
joelanman
reviewed
Sep 2, 2022
| @@ -1,6 +1,4 @@ | |||
| const express = require('express') | |||
| const router = express.Router() | |||
| /* eslint-disable-next-line no-unused-vars */ | |||
There was a problem hiding this comment.
is there any way for users to not get these lines, as they probably don't need them and they are a bit daunting
There was a problem hiding this comment.
Yeah, I think we should look at the starter kit as a whole and look at this line as part of it.
BenSurgisonGDS
suggested changes
Sep 2, 2022
CHANGELOG.md
Outdated
| @@ -12,7 +12,7 @@ | |||
| - Assets and Javascript are served from their location in the app folder rather than being copied to a public folder | |||
| - Generated assets are all inside .tmp | |||
| - The core prototype-kit files have been moved into the package | |||
| - The start script uses the new govuk-prototype-kit cli | |||
| - The start script uses the new uk-prototype-kit cli | |||
There was a problem hiding this comment.
Has govuk-prototype-kit been changed to uk-prototype-kit by mistake?
nataliecarey
force-pushed
the
setup-router-api
branch
from
6c315bf
to
91eed1a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-setup-rout-frgzph
BenSurgisonGDS
approved these changes
Sep 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the user to create a router.
We explored ideas around more fine grained control instead of providing router functionality but I've reconsidered and think that's better to grow over time alongside providing routers. We can deprecate the routers at a later date if we want to replace them with more fine grained methods.