Making most files optional #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
reviewed
Sep 22, 2022
nataliecarey
force-pushed
the
making-most-files-optional
branch
from
2b8163f
to
f9c6626
Compare
nataliecarey
force-pushed
the
making-most-files-optional
branch
from
06c5aeb
to
7c1cb43
Compare
BenSurgisonGDS
approved these changes
Sep 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we've moved to using the kit as a package we've been gradually making more files optional. By optional I mean that the kit can start without those files being present. This PR makes the rest of the files optional that hadn't been picked up on other pieces of work.
The only one remaining is
application.scsswhich is made optional in this PR #1615