V13 pre refactor #1624
Merged
V13 pre refactor #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenSurgisonGDS
force-pushed
the
v13-pre-refactor
branch
from
a20b0c9
to
3b6c7b4
Compare
BenSurgisonGDS
force-pushed
the
v13-pre-refactor
branch
2 times, most recently
from
b671132
to
f43a0b1
Compare
lfdebrux
reviewed
Sep 28, 2022
| try { | ||
| return fse.readJsonSync(appConfigPath) | ||
| } catch (e) { | ||
| console.error(`Could not load config from ${appConfigPath}, please check your JSON is well formed.`) |
There was a problem hiding this comment.
Not sure how this error message will read to someone who isn't a developer, @NoraGDS what do you think?
There was a problem hiding this comment.
Would you be happier if this said something like "Could not load config from ${appConfigPath}, please check your configuration is formatted correctly."
There was a problem hiding this comment.
Or would you prefer I revert the catch here also?
There was a problem hiding this comment.
@lfdebrux doesn't ready too well. Can we say 'Check your configuration is formatted correctly in (whatever place it's in)'
lfdebrux
reviewed
Sep 28, 2022
BenSurgisonGDS
force-pushed
the
v13-pre-refactor
branch
2 times, most recently
from
cbd118e
to
bfea15b
Compare
lfdebrux
reviewed
Sep 28, 2022
| 5. Update the [CHANGELOG.md](/CHANGELOG.md) by: | ||
| 6. Update the [CHANGELOG.md](/CHANGELOG.md) by: |
BenSurgisonGDS
force-pushed
the
v13-pre-refactor
branch
from
76a64a2
to
46a1a50
Compare
lfdebrux
approved these changes
Sep 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare V13 for a refactor to allow plugins/extensions to be added without restarting the application: