Move default user template to app/views/layouts/main.html #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make sure that when users can override Nunjucks templates in the kit and plugins by creating a file with the same path/filename. This commit moves the `app/views` folder where a user keeps their templates to the top of the Nunjucks folders list, so that Nunjucks will look there for templates first.
This should make restoring files to their default state easier.
We've moved app/views/layout.html to app/views/layouts/main.html in the prototype starter, but we don't yet want the migration script to change layouts in existing prototypes, because that would require a lot of extra code to handle updating every Nunjucks template. This does mean though that we need to tweak the script a bit to be able to copy from the starter files to the existing layout.
In cases where the user has deleted their default layout file, we still want their prototype to work, so we add a fallback in the kit. Because the Nunjucks environment has the location in `lib/nunjucks` at a lower priority, this file will only be used if the user doesn't have a similarly named file in `app/views/layout`.
5 tasks
lfdebrux
changed the title
BenSurgisonGDS
approved these changes
Nov 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes changes listed in #1707.