Drop support for Node.js 12, 14 #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-no-node-12-14
branch
2 times, most recently
from
5de6e35
to
8fe13ae
Compare
BenSurgisonGDS
approved these changes
Nov 8, 2022
Node 12 has reached end of life (EOL), and Node 14 will reach end of life within the lifetime of GOV.UK Prototype Kit 13. Users shouldn't be using EOL versions of Node, as they do not receive security fixes. Let's stop supporting these versions, to reduce our maintenance burden. This commit removes them from the test matrix and the `engines.node` property of the package.json. We also update the engines directive to make it clear we only support LTS versions.
lfdebrux
force-pushed
the
ldeb-no-node-12-14
branch
from
8fe13ae
to
f835fc5
Compare
This was referenced Nov 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12 has reached end of life (EOL), and Node 14 will reach end of life within the lifetime of GOV.UK Prototype Kit 13. Users shouldn't be using EOL versions of Node, as they do not receive security fixes. Let's stop supporting these versions, to reduce our maintenance burden. This commit removes them from the test matrix and the engines directive of the package.json.
Part of #1124.