-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep existing package name when migrating #1791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenSurgisonGDS
force-pushed
the
retain-original-package-name-property
branch
from
November 18, 2022 15:53
d141c9a
to
1796a55
Compare
BenSurgisonGDS
force-pushed
the
retain-original-package-name-property
branch
from
November 22, 2022 11:00
1796a55
to
086d1b9
Compare
BenSurgisonGDS
force-pushed
the
retain-original-package-name-property
branch
2 times, most recently
from
November 24, 2022 14:50
eab4c14
to
b03e716
Compare
lfdebrux
reviewed
Nov 25, 2022
lfdebrux
reviewed
Nov 25, 2022
BenSurgisonGDS
force-pushed
the
retain-original-package-name-property
branch
2 times, most recently
from
November 25, 2022 13:21
8a2470d
to
63293c7
Compare
lfdebrux
reviewed
Nov 25, 2022
@@ -44,6 +44,28 @@ describe('migrate test prototype', () => { | |||
}) | |||
}) | |||
|
|||
it('package.json', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
lfdebrux
approved these changes
Nov 25, 2022
lfdebrux
changed the title
Retain original package name property
Keep package name when migrating existing prototypes
Nov 25, 2022
lfdebrux
changed the title
Keep package name when migrating existing prototypes
Keep existing package name when migrating
Nov 25, 2022
Oh we should add this to the changelog |
BenSurgisonGDS
force-pushed
the
retain-original-package-name-property
branch
from
November 25, 2022 14:25
63293c7
to
a7ffd8c
Compare
BenSurgisonGDS
force-pushed
the
retain-original-package-name-property
branch
from
November 25, 2022 14:29
b0bd8a0
to
7edb0ec
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.