Stop installing dev dependencies when creating prototype #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce duplication of code and improve consistency.
Fixes issue #1799. We use npm shrinkwrap to try and improve security for users, however the shrinkwrap file includes dev dependencies, and a bug in npm [[1]] means that users are getting the dev dependencies whenever they create a new prototype. This commit changes the publishing process so that these dev dependencies are removed from package.json and npm-shrinkwrap.json, using the tool [clean-publish]. [1]: npm/cli#4323 [clean-publish]: https://github.com/shashkovdanil/clean-publish#readme
The previous commit stopped publishing govuk-prototype-kit with dev dependencies; this commit stops any dev dependencies being installed when creating a new prototype with the cli tool. We take this belt-and-braces approach to handle older versions of the kit package, or potential future versions where we don't bother to modify `npm-shrinkwrap.json` because npm have fixed their bugs.
BenSurgisonGDS
approved these changes
Nov 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1799.
This PR takes a belt-and-braces approach to fixing the issue; we both stop publishing the package with dev dependencies, and stop npm from installing any dev dependencies when creating a prototype.