Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previewing templates with JavaScript in management pages #1804

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Nov 23, 2022

See: #1763

Make sure the javascript from available extensions are loaded in the view

@lfdebrux lfdebrux self-requested a review November 23, 2022 16:12
@BenSurgisonGDS BenSurgisonGDS force-pushed the fix-template-preview-with-javascript branch 2 times, most recently from 54af7c0 to 541ee7a Compare November 24, 2022 12:38
lib/utils.js Outdated Show resolved Hide resolved
@BenSurgisonGDS BenSurgisonGDS force-pushed the fix-template-preview-with-javascript branch from 4464d8f to 65d9453 Compare November 24, 2022 14:40
@BenSurgisonGDS BenSurgisonGDS merged commit c87bf1c into main Nov 24, 2022
@BenSurgisonGDS BenSurgisonGDS deleted the fix-template-preview-with-javascript branch November 24, 2022 14:47
@lfdebrux
Copy link
Member

Woops, I forgot when reviewing that this change should go in the changelog

@lfdebrux lfdebrux changed the title Fix previewing templates with javascript in management pages Fix previewing templates with JavaScript in management pages Nov 25, 2022
lfdebrux added a commit that referenced this pull request Nov 25, 2022
@lfdebrux lfdebrux mentioned this pull request Dec 6, 2022
@lfdebrux lfdebrux added this to the v13.0.1 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previewing templates with JavaScript in management pages does not work
2 participants