Fix crashes when path to prototype contains spaces #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a user unable to use the migration script because the path to their prototype included spaces. Fix this by not `spawn`ing via the shell in `bin/cli`; we don't need to, and this way we don't need to worry about escaping command line arguments.
lfdebrux
force-pushed
the
ldeb-fix-1840
branch
from
a3884ef
to
462670f
Compare
On Windows using `spawn('npm', ...)` raises an ENOENT error, because of
PATHEXT issues. Using [cross-spawn] fixes this.
[cross-spawn]: https://www.npmjs.com/package/cross-spawn
BenSurgisonGDS
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1840
We had a user unable to use the migration script because the path to their prototype included spaces. Fix this by not
spawning via the shell inbin/cli; we don't need to, and this way we don't need to worry about escaping command line arguments.