Stop user's home path from being printed in migration script log #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure paths are always logged as relative to the project directory, to keep them short and easier to read.
lfdebrux
force-pushed
the
ldeb-redact-home-path
branch
2 times, most recently
from
34c6bd7
to
23c3c82
Compare
lfdebrux
changed the title
lfdebrux
force-pushed
the
ldeb-redact-home-path
branch
from
23c3c82
to
993f1fe
Compare
lfdebrux
force-pushed
the
ldeb-redact-home-path
branch
from
993f1fe
to
27a4470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the logging of paths by the migration script more consistent, closing #1816.
It also works to ensure that the user's home path won't end up in
migrate.log, so their computer username is now less likely to leak.