-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve path validation of templated created pages #1848
Improve path validation of templated created pages #1848
Conversation
bed3ac7
to
fca8c74
Compare
don't have time for a full review until later, but one point - I think we talk about a 'path' on the page, and have 'URL' in the errors - we should use 'path' throughout |
216f1da
to
55e9837
Compare
having problems checking this out to test - I've tried
and I get
|
.should('contains.text', 'Create new Start page') | ||
cy.get('.govuk-label') | ||
.should('contains.text', 'Path for the new page') | ||
cy.get('#chosen-url') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering if we should use path
throughout, unless we are sometimes dealing with urls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The headings on the page were not part of the PR. The only reason they are referenced is to for the acceptance tests. Should this be in another PR?
it should not allow paths with multiple consecutive slashes |
7385c62
to
2a2865e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs a changelog
fddfe72
to
88da3ba
Compare
See: You can create a page from a template with no name
Added validation and acceptance tests for: