Migration will now report head and script failures #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenSurgisonGDS
force-pushed
the
migration-script-will-now-report-head-and-script-failures
branch
from
d5b1ac5
to
8ff081c
Compare
|
Would it be OK to add a test to avoid this issue reappearing after a refactor please? |
Added test to make sure additional step is always called if it exists
BenSurgisonGDS
force-pushed
the
migration-script-will-now-report-head-and-script-failures
branch
from
8ff081c
to
1f3dc3e
Compare
New test added to make sure the additional step (deleting head.html and script.html) occurs even when the layout.html has not been changed. |
nataliecarey
approved these changes
Dec 19, 2022
BenSurgisonGDS
deleted the
migration-script-will-now-report-head-and-script-failures
branch
BenSurgisonGDS
added a commit
that referenced
this pull request
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: Migration script does not always migrate app/views/includes/{head, scripts}.html