Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a git repository for new prototypes (when git is present) #1860

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

nataliecarey
Copy link
Contributor

@nataliecarey nataliecarey commented Dec 19, 2022

Ticket: #1670

This will make the initial commit as the current user if they have set up a email address etc. in git, if they haven't set that up it will be committed as the Prototype Kit with the team email address - this is mostly for CI but it would also be useful for a user who has just set up a new computer and hasn't set up git properly yet.

As each of the test clients have git installed I have manually tested on an Ubuntu VM without git. It works.

@nataliecarey nataliecarey marked this pull request as draft December 20, 2022 12:14
@nataliecarey nataliecarey force-pushed the git-init branch 11 times, most recently from 6a66b92 to 2195812 Compare December 20, 2022 14:54
@nataliecarey nataliecarey marked this pull request as ready for review December 20, 2022 15:40
@lfdebrux
Copy link
Member

Thanks @nataliecarey. I think this needs an entry in the changelog?

@nataliecarey
Copy link
Contributor Author

Thanks for the reminder @lfdebrux. Updated.

@lfdebrux lfdebrux changed the title Initialise git repo when creating a kit. Create a git repository for new prototypes (when git is present) Dec 22, 2022
@joelanman
Copy link
Contributor

@nataliecarey would be good to go through the user experience of this with you to review

bin/cli Show resolved Hide resolved
…e with git but no user configured (as it is on CI).
@nataliecarey nataliecarey merged commit 9348e0c into main Dec 22, 2022
@nataliecarey nataliecarey deleted the git-init branch December 22, 2022 16:01
@joelanman
Copy link
Contributor

Some notes as I wasn't able to review before the merge happened:

  • the commit here is by Your Name <you@example.com> - this seems like a mistake?
  • there's a typo meaningulLines
  • The message should be just 'Create prototype' (not 'kit') to match our documentation, and I think Git practice is to have 'Create' rather than 'Created'? https://stackoverflow.com/a/3580764
  • this creates a master branch by default - should we change it to main?

@joelanman
Copy link
Contributor

@lfdebrux lfdebrux linked an issue Jan 3, 2023 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialise git repo
4 participants