-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a git repository for new prototypes (when git is present) #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliecarey
force-pushed
the
git-init
branch
8 times, most recently
from
December 20, 2022 12:13
76a6ad3
to
ecbbfd2
Compare
nataliecarey
force-pushed
the
git-init
branch
11 times, most recently
from
December 20, 2022 14:54
6a66b92
to
2195812
Compare
nataliecarey
force-pushed
the
git-init
branch
4 times, most recently
from
December 22, 2022 09:59
b992b81
to
390ac72
Compare
Thanks @nataliecarey. I think this needs an entry in the changelog? |
nataliecarey
force-pushed
the
git-init
branch
from
December 22, 2022 11:09
390ac72
to
467f150
Compare
Thanks for the reminder @lfdebrux. Updated. |
lfdebrux
changed the title
Initialise git repo when creating a kit.
Create a git repository for new prototypes (when git is present)
Dec 22, 2022
@nataliecarey would be good to go through the user experience of this with you to review |
lfdebrux
reviewed
Dec 22, 2022
…e with git but no user configured (as it is on CI).
nataliecarey
force-pushed
the
git-init
branch
from
December 22, 2022 12:14
467f150
to
fa2c553
Compare
BenSurgisonGDS
approved these changes
Dec 22, 2022
Some notes as I wasn't able to review before the merge happened:
|
we should also have a look at updating our git guidance |
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1670
This will make the initial commit as the current user if they have set up a email address etc. in git, if they haven't set that up it will be committed as the Prototype Kit with the team email address - this is mostly for CI but it would also be useful for a user who has just set up a new computer and hasn't set up git properly yet.
As each of the test clients have git installed I have manually tested on an Ubuntu VM without git. It works.