Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Common templates to the Common templates plugin #1923

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Move Common templates to the Common templates plugin #1923

merged 5 commits into from
Jan 31, 2023

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Jan 20, 2023 •
edited
Loading

See:

Changes:

  • Removed the common templates as they are now provided by the common templates plugin
  • Removed the common template references within the kit plugin config
  • Added the plugin scope to each installed plugin in the templates page
  • Added a link to install the common templates plugin in the templates page
  • Updated the change log

@BenSurgisonGDS BenSurgisonGDS force-pushed the move-common-templates-to-common-templates-plugin branch 3 times, most recently from 4262f0e to 24cc61f Compare January 23, 2023 10:43
@BenSurgisonGDS BenSurgisonGDS linked an issue Jan 23, 2023 that may be closed by this pull request
Move templates and patterns to plugins #1653
Closed
7 tasks
@BenSurgisonGDS BenSurgisonGDS force-pushed the move-common-templates-to-common-templates-plugin branch 9 times, most recently from 657e1d0 to ce2996f Compare January 27, 2023 18:31
@BenSurgisonGDS BenSurgisonGDS force-pushed the move-common-templates-to-common-templates-plugin branch from 956a245 to bb1d083 Compare January 30, 2023 09:49
@BenSurgisonGDS BenSurgisonGDS mentioned this pull request Jan 30, 2023
Merged
@nataliecarey
Copy link
Contributor

I think it's worth putting in a query parameter to say we should move back to templates after installing from the templates page.

nataliecarey
nataliecarey reviewed Jan 30, 2023
View reviewed changes
cypress/e2e/plugins/1-available-plugins-tests/available-plugins.cypress.js

describe('Plugin tests', () => {
installPluginTests({
plugin: '@govuk-prototype-kit/common-templates',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin the version to avoid flaky tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nataliecarey nataliecarey force-pushed the move-common-templates-to-common-templates-plugin branch from 9d61740 to 53602ea Compare January 30, 2023 16:09
@BenSurgisonGDS BenSurgisonGDS force-pushed the move-common-templates-to-common-templates-plugin branch from a32e9f6 to 1a130ff Compare January 30, 2023 18:58
@BenSurgisonGDS BenSurgisonGDS force-pushed the move-common-templates-to-common-templates-plugin branch from 1a130ff to 50864fb Compare January 30, 2023 19:13
@BenSurgisonGDS BenSurgisonGDS merged commit a288aa2 into main Jan 31, 2023
@BenSurgisonGDS BenSurgisonGDS deleted the move-common-templates-to-common-templates-plugin branch January 31, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliecarey nataliecarey nataliecarey approved these changes

@joelanman joelanman Awaiting requested review from joelanman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move templates and patterns to plugins
2 participants
@BenSurgisonGDS @nataliecarey