Fixing create message #1929
Merged
Fixing create message #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliecarey
force-pushed
the
fix-create-message
branch
from
24fcfcb
to
fd1c981
Compare
nataliecarey
force-pushed
the
fix-create-message
branch
from
fd1c981
to
3ac71ef
Compare
BenSurgisonGDS
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we released
v13.2.0andv13.2.1we knew we had to work with situations where an older installer creates a new version of the kit. What we implemented inv13.2.0worked with a new installer but not an old installer, what we implemented inv13.2.1works with an old installer but not with a new installer. This version recognises thatcreateandinitneed to be handled separately even though they're in the same file because they can be run from different versions.To test the current live version:
npx govuk-prototype-kit@13.2.1 create ~/somewhereTo test this version:
npx govuk-prototype-kit@github:alphagov/govuk-prototype-kit#fix-create-message create --version=alphagov/govuk-prototype-kit#fix-create-message ~/somewhereYou can also mix older versions and newer versions e.g. this installer running with an older kit where you'd expect to see no status messages:
npx govuk-prototype-kit@github:alphagov/govuk-prototype-kit#fix-create-message create --version=13.0.0 ~/somewhereor an older installer running this version of the kit where you'd expect also expect to see no status messages:
npx govuk-prototype-kit@13.0.0 create --version=alphagov/govuk-prototype-kit#fix-create-message ~/somewhereAnd then the you'll see the full output (three status messages) by running this version of the installer with this version of the kit:
npx govuk-prototype-kit@github:alphagov/govuk-prototype-kit#fix-create-message create --version=alphagov/govuk-prototype-kit#fix-create-message ~/somewhere