Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make notifications node client available #1962

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Make notifications node client available #1962

merged 2 commits into from
Feb 13, 2023

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Feb 8, 2023 •
edited
Loading

See Make Notify client a Plugin

  • Added notifications-node-client to the list of known plugins
  • Allow known plugins to be installed without a plugin config
  • Simplify some of the functionality
  • Rename some functions to make them easier for the new starters
  • Allow install.js test to pass in windows node 18.x (This shouldn't have been affected by this change, but was)

@BenSurgisonGDS BenSurgisonGDS force-pushed the make-notifications-node-client-available branch from 3b79e90 to 5728e58 Compare February 8, 2023 17:38
@BenSurgisonGDS BenSurgisonGDS force-pushed the make-notifications-node-client-available branch from 4d3c25f to d1f72e2 Compare February 10, 2023 17:47
@BenSurgisonGDS BenSurgisonGDS marked this pull request as ready for review February 10, 2023 18:12
@BenSurgisonGDS BenSurgisonGDS linked an issue Feb 10, 2023 that may be closed by this pull request
Make Notify client a Plugin #1710
Closed
3 tasks
@BenSurgisonGDS BenSurgisonGDS requested a review from a team February 10, 2023 18:42
@BenSurgisonGDS BenSurgisonGDS force-pushed the make-notifications-node-client-available branch 2 times, most recently from 33b99aa to f9edfdc Compare February 10, 2023 19:20
@BenSurgisonGDS BenSurgisonGDS force-pushed the make-notifications-node-client-available branch from f9edfdc to c8f0811 Compare February 10, 2023 19:36
@BenSurgisonGDS BenSurgisonGDS merged commit 3f3ec57 into main Feb 13, 2023
@BenSurgisonGDS BenSurgisonGDS deleted the make-notifications-node-client-available branch February 13, 2023 11:18
@BenSurgisonGDS BenSurgisonGDS mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliecarey nataliecarey nataliecarey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Notify client a Plugin
2 participants
@BenSurgisonGDS @nataliecarey