Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidating common session errors into one easier to read message. #1965

Closed
wants to merge 1 commit into from

Conversation

nataliecarey
Copy link
Contributor

The following console logs show up regularly for me:

[session-file-store] will retry, error on last attempt: Error: ENOENT: no such file or directory, open '/Users/natalie.carey/projects/prototype-kits/companion-prototype-kit/.tmp/sessions/WSerxmSthkoRku_lXY6etQJT-wHExmxL.json'
[session-file-store] will retry, error on last attempt: Error: ENOENT: no such file or directory, open '/Users/natalie.carey/projects/prototype-kits/companion-prototype-kit/.tmp/sessions/WSerxmSthkoRku_lXY6etQJT-wHExmxL.json'
[session-file-store] will retry, error on last attempt: Error: ENOENT: no such file or directory, open '/Users/natalie.carey/projects/prototype-kits/companion-prototype-kit/.tmp/sessions/WSerxmSthkoRku_lXY6etQJT-wHExmxL.json'
[session-file-store] will retry, error on last attempt: Error: ENOENT: no such file or directory, open '/Users/natalie.carey/projects/prototype-kits/companion-prototype-kit/.tmp/sessions/WSerxmSthkoRku_lXY6etQJT-wHExmxL.json'
[session-file-store] will retry, error on last attempt: Error: ENOENT: no such file or directory, open '/Users/natalie.carey/projects/prototype-kits/companion-prototype-kit/.tmp/sessions/WSerxmSthkoRku_lXY6etQJT-wHExmxL.json'

It happens when you start two kits with the same service name, that's something that will come up more regularly for us than for most users but it's likely to come up for our users sometimes. It can be reproduce by running:

npx create govuk-prototype-kit --version=13.2.4 kit1
npx create govuk-prototype-kit --version=13.2.4 kit2
cd kit1
npm run dev
[visit the homepage of the kit in the browser]
[in terminal press ^c to close the kit]
cd ../kit2
npm run dev
[visit the homepage of the kit in the browser]

I've put in a new error message but I think that wording can be improved. To see the new message run:

npx create govuk-prototype-kit --version=alphagov/govuk-prottoype-kit#session-error-message kit1
npx create govuk-prototype-kit -- version=alphagov/govuk-prottoype-kit#session-error-message kit2
cd kit1
npm run dev
[visit the homepage of the kit in the browser]
[in terminal press ^c to close the kit]
cd ../kit2
npm run dev
[visit the homepage of the kit in the browser]

@joelanman
Copy link
Contributor

related issue:

Can you paste the new output here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants