Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure install, upgrade and uninstall complete successfully. #1974

Merged
merged 8 commits into from
Feb 27, 2023
Merged

Make sure install, upgrade and uninstall complete successfully. #1974

merged 8 commits into from
Feb 27, 2023

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Feb 15, 2023 •
edited
Loading

Fixes the following:

  • Installs, Upgrades, and Uninstalls will complete successfully even on a slow connection
  • Multiple windows and tabs can be used to simulataneously initiate multiple Installs, Upgrades, and Uninstalls
  • Each action above within each window or tab is subject to a 30 second timeout on the front end.
  • Added unit tests for front end javascript

@BenSurgisonGDS BenSurgisonGDS marked this pull request as ready for review February 15, 2023 17:01
@BenSurgisonGDS BenSurgisonGDS force-pushed the use-kit-restarted-flag branch 3 times, most recently from 49ae5aa to f6127bb Compare February 16, 2023 08:43
@BenSurgisonGDS BenSurgisonGDS mentioned this pull request Feb 16, 2023
Closed
@BenSurgisonGDS BenSurgisonGDS force-pushed the use-kit-restarted-flag branch 2 times, most recently from 113780f to 50ef68a Compare February 16, 2023 13:48
@BenSurgisonGDS BenSurgisonGDS force-pushed the use-kit-restarted-flag branch 15 times, most recently from 91e684b to 9855354 Compare February 23, 2023 11:22
@BenSurgisonGDS BenSurgisonGDS merged commit 8699db0 into main Feb 27, 2023
@BenSurgisonGDS BenSurgisonGDS deleted the use-kit-restarted-flag branch February 27, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliecarey nataliecarey nataliecarey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenSurgisonGDS @nataliecarey @HannahJMWood