Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto update when settings created and removed #1988

Merged
merged 5 commits into from
Feb 20, 2023
Merged

Auto update when settings created and removed #1988

merged 5 commits into from
Feb 20, 2023

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Feb 18, 2023 •
edited
Loading

See Adding a settings.scss file requires a manual restart

  • Watch for the creation of the settings.scss file and add the include statement to the proxy sass file for settings.scss
  • Watch for the deletion of the settings.scss file and remove the include statement from the proxy sass file for settings.scss
  • Add a cypress test to make sure the functionality above works and the page updates as expected with the changes

@BenSurgisonGDS BenSurgisonGDS force-pushed the auto-restart-when-settings-created-and-removed branch 3 times, most recently from 6142af6 to 0311793 Compare February 20, 2023 10:09
@BenSurgisonGDS BenSurgisonGDS self-assigned this Feb 20, 2023
@BenSurgisonGDS BenSurgisonGDS linked an issue Feb 20, 2023 that may be closed by this pull request
Adding a settings.scss file requires a manual restart #1945
Closed
@BenSurgisonGDS BenSurgisonGDS force-pushed the auto-restart-when-settings-created-and-removed branch from 6da5643 to 8cf5068 Compare February 20, 2023 12:25
@BenSurgisonGDS BenSurgisonGDS marked this pull request as ready for review February 20, 2023 12:37
@BenSurgisonGDS BenSurgisonGDS force-pushed the auto-restart-when-settings-created-and-removed branch from 8cf5068 to 10c899b Compare February 20, 2023 12:40
@BenSurgisonGDS BenSurgisonGDS force-pushed the auto-restart-when-settings-created-and-removed branch from 10c899b to b233224 Compare February 20, 2023 12:47
@BenSurgisonGDS BenSurgisonGDS merged commit 57e34f7 into main Feb 20, 2023
@BenSurgisonGDS BenSurgisonGDS deleted the auto-restart-when-settings-created-and-removed branch February 20, 2023 15:03
@BenSurgisonGDS BenSurgisonGDS changed the title Auto restart when settings created and removed Auto update when settings created and removed Feb 21, 2023
@BenSurgisonGDS BenSurgisonGDS mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliecarey nataliecarey nataliecarey approved these changes

Assignees

@BenSurgisonGDS BenSurgisonGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a settings.scss file requires a manual restart
3 participants
@BenSurgisonGDS @nataliecarey @ollie-b-gds