Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing errors about session file store (issue 1733) #2021

Merged
merged 6 commits into from
Mar 8, 2023

Conversation

HannahJMWood
Copy link
Contributor

  • Using working directory path to create session name now (as the service name was frequently causing clashes)
  • Suppressed the number of duplicate error messages logged
  • Replaced standard sesssion-file-store warning with a custom warning message which is more useful to the user

Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the comment to indicate working directory is used.

lib/session.js Outdated Show resolved Hide resolved
@HannahJMWood HannahJMWood merged commit 1154112 into main Mar 8, 2023
@HannahJMWood HannahJMWood deleted the 1733_getting_errors_about_session_file_store branch March 8, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting errors about session file store when 2 prototypes have the same name
3 participants